• Scale raw ADC values in CSV and JSON parsers using calibration formula
• Parse CSV column headers to distinguish analog (ain*) from digital (dio*) columns
• Add comprehensive tests for ADC scaling with/without calibration config
• Fix digital data handling in CSV parser (previously treated as analog)

Add comprehensive ADC scaling tests for CSV parser

• Renamed test method to clarify DIO column behavior
• Added 4 new test cases for ADC scaling with calibration config
• Added tests for scaling with/without calibration and full formula validation
• Added tests for DIO column parsing and analog-only scaling
• Added test for ain column header parsing

src/Daqifi.Core.Tests/Device/SdCard/SdCardCsvFileParserTests.cs

Add ADC scaling tests for JSON parser

• Added 2 new test cases for ADC scaling in JSON parser
• Test scaling with calibration config (raw 22 → ~0.00336V)
• Test raw value passthrough when no calibration config provided

src/Daqifi.Core.Tests/Device/SdCard/SdCardJsonFileParserTests.cs

Implement ADC scaling and DIO column parsing in CSV parser

• Added CsvColumnLayout record to track analog pair count and digital pair presence
• Modified ParseHeader() to return both config and column layout, distinguishing ain* from dio*
 columns
• Updated TryParseCsvDataRow() to parse digital data separately from analog values
• Added ScaleRawAnalogValues() method implementing formula: (raw/resolution * portRange * calM +
 calB) * scaleM
• Updated ParseCsvLines() to apply scaling and pass digital data to log entries
• Updated documentation to reflect ain* column naming and raw ADC value scaling

src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs

Description

SdCardCsvFileParser.TryParseCsvDataRow returns null when no analog pairs are parsed, even if a DIO
pair is present, so CSV logs containing only dio_ts/dio_val will yield zero samples. This causes
silent data loss for digital-only configurations/files.

Code

src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs[R369-384]

+            // Parse digital I/O pair if present (last pair)
+            uint digitalData = 0;
+            if (layout.HasDigitalPair && totalPairs > analogPairCount)
+            {
+                var dioIndex = analogPairCount;
+                var dioValCol = columns[dioIndex * 2 + 1];
+                if (uint.TryParse(dioValCol, NumberStyles.None, CultureInfo.InvariantCulture, out var dioVal))
+                {
+                    digitalData = dioVal;
+                }
+            }
+
+            if (perChannelTimestamps.Count == 0)
+            {
+                return null;
+            }

Evidence

TryParseCsvDataRow only populates perChannelTimestamps while parsing analog pairs; when
analogPairCount is 0, perChannelTimestamps remains empty, digitalData can still be parsed, but the
method returns null and the caller skips the line. ParseHeader can produce a layout where
AnalogPairCount==0 and HasDigitalPair==true when the header indicates only a dio pair.

src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs[136-223]
src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs[341-388]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`TryParseCsvDataRow` drops rows when `analogPairCount == 0` (no analog channel pairs), even if a valid `dio_ts,dio_val` pair exists. This makes CSV files that contain only digital samples (or configurations with 0 analog channels) return no samples.
## Issue Context
- `TryParseCsvDataRow` only adds timestamps while parsing analog pairs.
- It parses `digitalData` from the presumed dio pair, then returns `null` when `perChannelTimestamps.Count == 0`.
- The caller treats `null` as a malformed row and skips it.
## Fix Focus Areas
- src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs[329-388]
- src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs[136-223]
## Implementation notes
- If `analogPairCount == 0` and `layout.HasDigitalPair` is true, parse `dio_ts` and use it as `rowTimestamp` for time reconstruction.
- Return an empty analog list and an empty (or null-equivalent) analog timestamp list rather than `null` so the row is emitted with `DigitalData` populated.
- Add/adjust a unit test for a `dio_ts,dio_val`-only CSV header + data row to prevent regression.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

SdCardCsvFileParser assumes the DIO pair is the last column pair by using dioIndex =
analogPairCount, but ParseHeader only records a boolean HasDigitalPair and does not enforce/record
the DIO pair position. If a CSV’s DIO pair is not last, digital values (and potentially analog
values) will be read from the wrong columns without errors.

Code

src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs[R369-379]

+            // Parse digital I/O pair if present (last pair)
+            uint digitalData = 0;
+            if (layout.HasDigitalPair && totalPairs > analogPairCount)
+            {
+                var dioIndex = analogPairCount;
+                var dioValCol = columns[dioIndex * 2 + 1];
+                if (uint.TryParse(dioValCol, NumberStyles.None, CultureInfo.InvariantCulture, out var dioVal))
+                {
+                    digitalData = dioVal;
+                }
+            }

Evidence

ParseHeader sets HasDigitalPair=true upon seeing any timestamp column starting with 'dio', but does
not record the index of that pair; TryParseCsvDataRow then assumes the dio pair sits exactly after
the analog pairs (i.e., last) by using dioIndex = analogPairCount. This only works when the dio
pair is last and all analog pairs precede it.

src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs[179-203]
src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs[341-379]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The CSV parser detects the presence of a DIO pair, but does not record its position. Row parsing then assumes the DIO pair is the last pair (`dioIndex = analogPairCount`), which will mis-parse files where the DIO columns are not last.
## Issue Context
- `ParseHeader` currently outputs `CsvColumnLayout(int AnalogPairCount, bool HasDigitalPair)`.
- `TryParseCsvDataRow` uses `dioIndex = analogPairCount` and reads `columns[dioIndex * 2 + 1]`.
## Fix Focus Areas
- src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs[126-223]
- src/Daqifi.Core/Device/SdCard/SdCardCsvFileParser.cs[329-388]
## Implementation notes
- Change `CsvColumnLayout` to store an optional `DigitalPairIndex` (e.g., `int? DigitalPairIndex` or `int DigitalPairIndex = -1`).
- In `ParseHeader`, record the pair index where the 'dio' columns appear and optionally validate that there is at most one.
- In `TryParseCsvDataRow`, parse analog pairs by skipping the digital pair index rather than assuming digital is last.
- Add a targeted unit test with a non-last DIO pair ordering to ensure correct behavior (or explicitly enforce and fail fast if non-last is unsupported).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools